Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 16157007: Revert 203873 "net_watcher does not build in Ubuntu 13.04" (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
yael.aharon
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 203873 "net_watcher does not build in Ubuntu 13.04" Broke Chrome Linux builds due to using #pragma GCC inside functions http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux&number=30432 http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=41197 > net_watcher does not build in Ubuntu 13.04 > > This is due to a deprecation warning in glib. Added a flag to suppress deprecation warnings. > BUG=245658 > > Review URL: https://chromiumcodereview.appspot.com/15792013 TBR=yael.aharon@intel.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M trunk/src/net/tools/net_watcher/net_watcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
7 years, 6 months ago (2013-06-04 07:05:56 UTC) #1
kinuko
7 years, 6 months ago (2013-06-04 07:06:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r203885.

Powered by Google App Engine
This is Rietveld 408576698