Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Inlined the variable androidUriSuffix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index 64171ad352a28358ca8e028cb0966be0a5cbd1c8..84735bc821b2de6ddc3bc6220a49e89ec9dc377c 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -158,6 +158,11 @@ class PasswordStore : protected PasswordStoreSync,
// The request will be cancelled if the consumer is destroyed.
virtual void GetAutofillableLogins(PasswordStoreConsumer* consumer);
+ // Same as above, but also fills in |affiliated_web_realm| for Android
+ // credentials.
+ virtual void GetAutofillableLoginsWithAffiliatedRealms(
+ PasswordStoreConsumer* consumer);
+
// Gets the complete list of PasswordForms that are blacklist entries,
// and notify |consumer| on completion. The request will be cancelled if the
// consumer is destroyed.
@@ -366,6 +371,11 @@ class PasswordStore : protected PasswordStoreSync,
// Finds all non-blacklist PasswordForms, and notifies the consumer.
void GetAutofillableLoginsImpl(scoped_ptr<GetLoginsRequest> request);
+ // Same as above, but also fills in |affiliated_web_realm| for Android
+ // credentials.
+ void GetAutofillableLoginsWithAffiliatedRealmsImpl(
+ scoped_ptr<GetLoginsRequest> request);
+
// Finds all blacklist PasswordForms, and notifies the consumer.
void GetBlacklistLoginsImpl(scoped_ptr<GetLoginsRequest> request);
@@ -373,6 +383,12 @@ class PasswordStore : protected PasswordStoreSync,
void NotifySiteStats(const GURL& origin_domain,
scoped_ptr<GetLoginsRequest> request);
+ // Notifies |request| about the autofillable logins with affiliated web
+ // realms for Android credentials.
+ void NotifyLoginsWithAffiliatedRealms(
+ scoped_ptr<GetLoginsRequest> request,
+ ScopedVector<autofill::PasswordForm> obtained_forms);
+
// Extended version of GetLoginsImpl that also returns credentials stored for
// the specified affiliated Android applications. That is, it finds all
// PasswordForms with a signon_realm that is either:
@@ -385,6 +401,11 @@ class PasswordStore : protected PasswordStoreSync,
scoped_ptr<GetLoginsRequest> request,
const std::vector<std::string>& additional_android_realms);
+ // Retrieves and fills in |affiliated_web_realm| values for Android
+ // credentials in |forms|. Called on the main thread.
+ void InjectAffiliatedWebRealms(ScopedVector<autofill::PasswordForm> forms,
+ scoped_ptr<GetLoginsRequest> request);
+
// Schedules GetLoginsWithAffiliationsImpl() to be run on the DB thread.
void ScheduleGetLoginsWithAffiliations(
const autofill::PasswordForm& form,

Powered by Google App Engine
This is Rietveld 408576698