Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: chrome/browser/resources/options/password_manager.js

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Inlined the variable androidUriSuffix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/options/password_manager_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/password_manager.js
diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js
index c41684550a9de2c846450711f98c4feabaabf5f1..a6ee22c8f0358b8225e528ee9b6b611567673ad0 100644
--- a/chrome/browser/resources/options/password_manager.js
+++ b/chrome/browser/resources/options/password_manager.js
@@ -178,16 +178,24 @@ cr.define('options', function() {
var columnWidth = entry.urlDiv.offsetWidth -
parseInt(computedStyle.webkitMarginStart, 10) -
parseInt(computedStyle.webkitPaddingStart, 10);
- if (columnWidth <= 0) {
- console.error('Estimated column width <= 0. Skip origins eliding.');
- return;
- }
for (var i = 0; i < entries.length; ++i) {
- var urlLink = entries[i].urlLink;
- if (entries[i].isAndroidUri || urlLink.offsetWidth <= columnWidth)
+ entry = entries[i];
+ // For android://com.example, elide from the right.
+ if (!entry.isClickable)
+ continue;
+ var cellWidth = columnWidth;
+ if (entry.androidUriSuffix)
+ cellWidth -= entry.androidUriSuffix.offsetWidth;
+ var urlLink = entry.urlLink;
+ if (cellWidth <= 0) {
+ console.error('cellWidth <= 0. Skip origins eliding for ' +
+ urlLink.textContent);
+ continue;
+ }
+ if (urlLink.offsetWidth <= cellWidth)
continue;
urlLink.textContent = '…' + urlLink.textContent.substring(1);
- while (urlLink.offsetWidth > columnWidth)
+ while (urlLink.offsetWidth > cellWidth)
urlLink.textContent = '…' + urlLink.textContent.substring(2);
}
},
@@ -204,9 +212,9 @@ cr.define('options', function() {
var query = this.lastQuery_;
var filter = function(entry, index, list) {
// Search both shown URL and username.
- var shownUrl = entry[options.passwordManager.SHOWN_URL_FIELD];
+ var shownOrigin = entry[options.passwordManager.SHOWN_ORIGIN_FIELD];
var username = entry[options.passwordManager.USERNAME_FIELD];
- if (shownUrl.toLowerCase().indexOf(query.toLowerCase()) >= 0 ||
+ if (shownOrigin.toLowerCase().indexOf(query.toLowerCase()) >= 0 ||
username.toLowerCase().indexOf(query.toLowerCase()) >= 0) {
// Keep the original index so we can delete correctly. See also
// deleteItemAtIndex() in password_manager_list.js that uses this.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/options/password_manager_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698