[Password manager] Human readable origins for Android credentials on chrome://settings/passwords

components/password_manager/core/browser/password_ui_utils.cc

Index: components/password_manager/core/browser/password_ui_utils.cc
diff --git a/components/password_manager/core/browser/password_ui_utils.cc b/components/password_manager/core/browser/password_ui_utils.cc
index d30e28b55e6cf79891d2891fc48a65a22415fe41..6207716da97e1db0d5d1133998b1cc5070a2241a 100644
--- a/components/password_manager/core/browser/password_ui_utils.cc
+++ b/components/password_manager/core/browser/password_ui_utils.cc
@@ -21,18 +21,33 @@ const char* const kRemovedPrefixes[] = {"m.", "mobile.", "www."};
 
 }  // namespace
 
-std::string GetShownOrigin(const autofill::PasswordForm& password_form,
-                           const std::string& languages,
-                           bool* is_android_uri) {
-  DCHECK(is_android_uri != nullptr);
+std::string GetShownOriginAndLinkUrl(
+    const autofill::PasswordForm& password_form,
+    const std::string& languages,
+    bool* is_android_uri,
+    GURL* link_url,
+    bool* origin_is_clickable) {
+  DCHECK(is_android_uri);
+  DCHECK(origin_is_clickable);
+  DCHECK(link_url);
 
   password_manager::FacetURI facet_uri =

[engedy, 2016/03/02 14:22:10]

You could use a shortcut here:

IsValidAndroidFacetURI(password_form.signon_realm); 

[kolos1, 2016/03/07 10:47:00]

I will need facet_uri later (for GetHumanReadableOriginForAndroidUri)

[engedy, 2016/03/08 17:36:38]

Acknowledged.

       password_manager::FacetURI::FromPotentiallyInvalidSpec(
           password_form.signon_realm);
   *is_android_uri = facet_uri.IsValidAndroidFacetURI();

[engedy, 2016/03/02 14:22:10]

How about:

if(IsValidAndroidFacetURI(password_form.signon_realm)) {
  *is_android_uri = true;
  ...

Don't forget to assign *is_android_uri = false otherwise.

[kolos1, 2016/03/07 10:47:00]

To be sure we always initialize *is_android_uri, I keep assignment before if. 

[engedy, 2016/03/08 17:36:38]

Acknowledged.

-  if (*is_android_uri)
-    return GetHumanReadableOriginForAndroidUri(facet_uri);
-
+  if (*is_android_uri) {
+    if (password_form.affiliated_web_realm.empty()) {
+      *origin_is_clickable = false;
+      *link_url = GURL(password_form.signon_realm);
+      return GetHumanReadableOriginForAndroidUri(facet_uri);
+    } else {

[engedy, 2016/03/02 14:22:10]

nit: The style guide discourages "else after return", please promote the body of
the else branch one indentation level.

[kolos1, 2016/03/07 10:47:00]

Done.

+      *origin_is_clickable = true;
+      *link_url = GURL(password_form.affiliated_web_realm);
+      return GetShownOrigin(*link_url, languages);
+    }
+  }
+  *origin_is_clickable = true;
+  *link_url = password_form.origin;
   return GetShownOrigin(password_form.origin, languages);
 }