Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: components/password_manager/core/browser/password_ui_utils_unittest.cc

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Transfer multi-request logic from PasswordStore to AffiliatedMatchHelper Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_ui_utils_unittest.cc
diff --git a/components/password_manager/core/browser/password_ui_utils_unittest.cc b/components/password_manager/core/browser/password_ui_utils_unittest.cc
index c757000abc6c566a195e10e095deacdfdd8b1c98..ab2648c8b7686819c6db2f1cd00e05e6d71d7deb 100644
--- a/components/password_manager/core/browser/password_ui_utils_unittest.cc
+++ b/components/password_manager/core/browser/password_ui_utils_unittest.cc
@@ -31,28 +31,59 @@ TEST(GetShownOriginTest, RemovePrefixes) {
for (const auto& test_case : kTestCases) {
autofill::PasswordForm password_form;
- password_form.signon_realm = "https://non.android.signon.com";
password_form.origin = GURL(test_case.input);
- bool is_android_uri;
- EXPECT_EQ(test_case.output,
- GetShownOrigin(password_form, "", &is_android_uri))
+ EXPECT_EQ(test_case.output, GetShownOrigin(password_form.origin, ""))
<< "for input " << test_case.input;
- EXPECT_FALSE(is_android_uri) << "for input " << test_case.input;
- EXPECT_EQ(test_case.output, GetShownOrigin(password_form.origin, ""));
}
}
-TEST(GetShownOriginTest, OriginFromAndroidForm) {
+TEST(GetShownOriginAndLinkUrlTest, OriginFromAndroidForm_NoAffiliatedRealm) {
autofill::PasswordForm android_form;
android_form.signon_realm =
"android://"
"m3HSJL1i83hdltRq0-o9czGb-8KJDKra4t_"
"3JRlnPKcjI8PZm6XBHXx6zG4UuMXaDEZjR1wuXDre9G9zvN7AQw=="
"@com.example.android";
- bool is_android_uri;
- EXPECT_EQ(GetShownOrigin(android_form, "", &is_android_uri),
+ android_form.affiliated_web_realm = "";
+
+ GURL link_url;
+ bool origin_is_clickable;
+ EXPECT_EQ(GetShownOriginAndLinkUrl(android_form, "", &link_url,
+ &origin_is_clickable),
"android://com.example.android");
- EXPECT_TRUE(is_android_uri);
+ EXPECT_FALSE(origin_is_clickable);
+ EXPECT_EQ(GURL(android_form.signon_realm), link_url);
+}
+
+TEST(GetShownOriginAndLinkUrlTest, OriginFromAndroidForm_WithAffiliatedRealm) {
+ autofill::PasswordForm android_form;
+ android_form.signon_realm =
+ "android://"
+ "m3HSJL1i83hdltRq0-o9czGb-8KJDKra4t_"
+ "3JRlnPKcjI8PZm6XBHXx6zG4UuMXaDEZjR1wuXDre9G9zvN7AQw=="
+ "@com.example.android";
+ android_form.affiliated_web_realm = "https://example.com";
+
+ GURL link_url;
+ bool origin_is_clickable;
+ EXPECT_EQ(GetShownOriginAndLinkUrl(android_form, "", &link_url,
+ &origin_is_clickable),
+ "example.com )Android(");
+ EXPECT_TRUE(origin_is_clickable);
+ EXPECT_EQ(GURL(android_form.affiliated_web_realm), link_url);
+}
+
+TEST(GetShownOriginAndLinkUrlTest, OriginFromNonAndroidForm) {
+ autofill::PasswordForm form;
+ form.signon_realm = "https://example.com";
+ form.origin = GURL("https://example.com/login?ref=1");
+
+ GURL link_url;
+ bool origin_is_clickable;
+ EXPECT_EQ(GetShownOriginAndLinkUrl(form, "", &link_url, &origin_is_clickable),
+ "example.com");
+ EXPECT_TRUE(origin_is_clickable);
+ EXPECT_EQ(form.origin, link_url);
}
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698