Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: components/password_manager/core/browser/password_ui_utils.h

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Transfer multi-request logic from PasswordStore to AffiliatedMatchHelper Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_ui_utils.h
diff --git a/components/password_manager/core/browser/password_ui_utils.h b/components/password_manager/core/browser/password_ui_utils.h
index b0e516c3ef3f68153058b28d419ef3fd9967b1ba..39939b758b467f41500f96b35accee04e8fef638 100644
--- a/components/password_manager/core/browser/password_ui_utils.h
+++ b/components/password_manager/core/browser/password_ui_utils.h
@@ -19,13 +19,19 @@ namespace password_manager {
// Returns a string suitable for security display to the user (just like
// |FormatUrlForSecurityDisplayOmitScheme| based on origin of |password_form|
-// and |languages|) and without prefixes "m.", "mobile." or "www.". For Android
-// URIs, returns the result of GetHumanReadableOriginForAndroidUri and sets
-// |*is_android_uri| to true, otherwise |*is_android_uri| is set to false.
-// |is_android_uri| is required to be non-null.
-std::string GetShownOrigin(const autofill::PasswordForm& password_form,
- const std::string& languages,
- bool* is_android_uri);
+// and |languages|) and without prefixes "m.", "mobile." or "www.". Also returns
+// the full URL of the origin as |link_url|.
+// For Android forms with empty |password_form.affiliated_web_realm|,
+// returns the result of GetHumanReadableOriginForAndroidUri. For other Android
+// forms, returns |password_form.affiliated_web_realm|.
+// |*origin_is_clickable| is set to true, except for Android forms with empty
+// |password_form.affiliated_web_realm|.
+// |link_url| and |origin_is_clickable| are required to non-null.
+std::string GetShownOriginAndLinkUrl(
+ const autofill::PasswordForm& password_form,
+ const std::string& languages,
+ GURL* link_url,
+ bool* origin_is_clickable);
// Returns a string suitable for security display to the user (just like
// |FormatUrlForSecurityDisplayOmitScheme| based on origin of |password_form|

Powered by Google App Engine
This is Rietveld 408576698