build/vs_toolchain.py - Issue 1615603002: Fix gn builds with locally installed VS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 1615603002: Fix gn builds with locally installed VS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaked comments and removed test code Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 66a3cd8e8640147ffaa07bd930dc3252f99bd45e..1ed953de2fb97e5dd261b65bf47681a91aa62fb9 100755

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -329,7 +329,7 @@ def GetToolchainDir():

# If WINDOWSSDKDIR is not set, search the default SDK path and set it.

if not 'WINDOWSSDKDIR' in os.environ:

- default_sdk_path = 'C:\\Program Files (x86)\\Windows Kits\\8.1'

+ default_sdk_path = 'C:\\Program Files (x86)\\Windows Kits\\10'

if os.path.isdir(default_sdk_path):

os.environ['WINDOWSSDKDIR'] = default_sdk_path

« no previous file with comments | « build/toolchain/win/setup_toolchain.py ('k') | no next file » | no next file with comments »