Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 16156013: Implement metadata for instance fields. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, karlklose
Visibility:
Public.

Description

Implement metadata for instance fields. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23580

Patch Set 1 : #

Patch Set 2 : Found an issue during testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -26 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 6 chunks +26 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart View 1 8 chunks +52 lines, -11 lines 0 comments Download
M dart/tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/lib/mirrors/metadata_test.dart View 3 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
7 years, 6 months ago (2013-06-03 13:40:05 UTC) #1
kasperl
LGTM.
7 years, 6 months ago (2013-06-03 13:53:10 UTC) #2
ahe
Found an issue with native/intercepted classes during testing, minor tweak to the code in Patch ...
7 years, 6 months ago (2013-06-03 14:13:59 UTC) #3
kasperl
LGTM.
7 years, 6 months ago (2013-06-04 05:34:38 UTC) #4
ahe
7 years, 6 months ago (2013-06-04 08:08:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r23580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698