third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp - Issue 1615573002: Set rootBounds to null for cross-origin observations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp

Issue 1615573002: Set rootBounds to null for cross-origin observations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Get rid of js-test.js monkey patching Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserverEntry.h ('k') | third_party/WebKit/Source/core/dom/IntersectionObserverEntry.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp

index 1511a2a4692f30115cb919e2926ffec36c2b95c1..a3d358b03ec9196530d3394f1c6c944ee88d0884 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp

@@ -8,10 +8,10 @@

namespace blink {

-IntersectionObserverEntry::IntersectionObserverEntry(double time, const IntRect& boundingClientRect, const IntRect& rootBounds, const IntRect& intersectionRect, Element* target)

+IntersectionObserverEntry::IntersectionObserverEntry(double time, const IntRect& boundingClientRect, const IntRect* rootBounds, const IntRect& intersectionRect, Element* target)

: m_time(time)

, m_boundingClientRect(ClientRect::create(boundingClientRect))

- , m_rootBounds(ClientRect::create(rootBounds))

+ , m_rootBounds(rootBounds ? ClientRect::create(*rootBounds) : nullptr)

, m_intersectionRect(ClientRect::create(intersectionRect))

, m_target(target)