third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 1615523002: Transitively keep track of an isolated world's children scripts and worlds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 1615523002: Transitively keep track of an isolated world's children scripts and worlds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a static world stack instead of a per-world private field Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h ('k') | third_party/WebKit/Source/core/dom/ScriptLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

index a6c7caf66d208e3b4b93eb65f7adf0353b770e29..9671b2e6bb6860c7930bcb3b4051f18c80df0590 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -46,6 +46,7 @@ V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, DOMWrapperWor

: EventListener(JSEventListenerType)

, m_isAttribute(isAttribute)

, m_world(world)

+ , m_originWorld(PassRefPtr<DOMWrapperWorld>(world.originWorld()))

, m_isolate(isolate)

, m_workerGlobalScope(nullptr)

{

@@ -91,11 +92,14 @@ void V8AbstractEventListener::handleEvent(ScriptState* scriptState, Event* event

RefPtrWillBeRawPtr<V8AbstractEventListener> protect(this);

ScriptState::Scope scope(scriptState);

+ // Ensure the origin world gets propagated to the event and is reset afterwards.

+ DOMWrapperWorld::OriginWorldScope worldScope(m_originWorld);

// Get the V8 wrapper for the event object.

v8::Local<v8::Value> jsEvent = toV8(event, scriptState->context()->Global(), isolate());

if (jsEvent.IsEmpty())

return;

invokeEventHandler(scriptState, event, v8::Local<v8::Value>::New(isolate(), jsEvent));

}