Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1615493002: Call to URLDataManagerIOS::DeleteDataSources during shutdown (Closed)

Created:
4 years, 11 months ago by stuartmorgan
Modified:
4 years, 11 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call to URLDataManagerIOS::DeleteDataSources during shutdown This matches the content version of shutdown, and was missing due to a merge mistake during the time when iOS shared the content main loop code, with significant diffing. BUG=412727 Committed: https://crrev.com/f67c2201cc7305b45181aac0d78e6416e52ba8e1 Cr-Commit-Position: refs/heads/master@{#370653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/web/app/web_main_loop.mm View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stuartmorgan
4 years, 11 months ago (2016-01-20 22:21:06 UTC) #2
blundell
lgtm
4 years, 11 months ago (2016-01-21 08:33:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615493002/1
4 years, 11 months ago (2016-01-21 08:34:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 08:52:59 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 08:53:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f67c2201cc7305b45181aac0d78e6416e52ba8e1
Cr-Commit-Position: refs/heads/master@{#370653}

Powered by Google App Engine
This is Rietveld 408576698