Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1615473002: Revert of Fix GrAtlasTextBlob bounds management (Closed)

Created:
4 years, 11 months ago by joshualitt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext17
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix GrAtlasTextBlob bounds management (patchset #8 id:140001 of https://codereview.chromium.org/1605013002/ ) Reason for revert: seems to break upright matrix Original issue's description: > Fix GrAtlasTextBlob bounds management > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605013002 > > Committed: https://skia.googlesource.com/skia/+/ae473fdfc3db2d9dd82b05b2568767d6d4038fcd TBR=bsalomon@google.com,jvanverth@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/269a82f2883cbd108d74f69bfa99cc2fdf8fe896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -68 lines) Patch
M src/gpu/batches/GrAtlasTextBatch.h View 1 chunk +3 lines, -20 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 8 chunks +10 lines, -32 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 3 chunks +3 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
joshualitt
Created Revert of Fix GrAtlasTextBlob bounds management
4 years, 11 months ago (2016-01-20 21:54:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615473002/1
4 years, 11 months ago (2016-01-20 21:54:24 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 21:54:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/269a82f2883cbd108d74f69bfa99cc2fdf8fe896

Powered by Google App Engine
This is Rietveld 408576698