Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
index c4c1d8f8d862d99d474bb1f4511da480c3c44e4d..e3f5b9334e1c6baabd5cdda8bbf14f36c85f40d5 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
@@ -201,7 +201,7 @@ PassRefPtr<SkImageFilter> FilterEffect::createImageFilterWithoutValidation(SkiaI
PassRefPtr<SkImageFilter> FilterEffect::createTransparentBlack(SkiaImageFilterBuilder& builder) const
{
SkAutoTUnref<SkColorFilter> filter(SkColorFilter::CreateModeFilter(0, SkXfermode::kClear_Mode));
- SkImageFilter::CropRect rect = getCropRect(builder.cropOffset());
+ SkImageFilter::CropRect rect = getCropRect();
return adoptRef(SkColorFilterImageFilter::Create(filter, nullptr, &rect));
}
@@ -215,7 +215,7 @@ bool FilterEffect::hasConnectedInput() const
return false;
}
-SkImageFilter::CropRect FilterEffect::getCropRect(const FloatSize& cropOffset) const
+SkImageFilter::CropRect FilterEffect::getCropRect() const
{
FloatRect rect;
uint32_t flags = 0;
@@ -226,7 +226,6 @@ SkImageFilter::CropRect FilterEffect::getCropRect(const FloatSize& cropOffset) c
rect = applyEffectBoundaries(rect);
- rect.move(cropOffset);
rect.scale(filter()->scale());
flags |= hasX() ? SkImageFilter::CropRect::kHasLeft_CropEdge : 0;

Powered by Google App Engine
This is Rietveld 408576698