third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp - Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

index 680b43eab38cdf7753f9c95ee9e8220f266749ce..cefff6187c5320903b9a1e6db36412144dd53c6f 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

@@ -63,7 +63,7 @@ PassRefPtr<SkImageFilter> FELighting::createImageFilter(SkiaImageFilterBuilder&

if (!m_lightSource)

return createTransparentBlack(builder);

- SkImageFilter::CropRect rect = getCropRect(builder.cropOffset());

+ SkImageFilter::CropRect rect = getCropRect();

Color lightColor = adaptColorToOperatingColorSpace(m_lightingColor);

RefPtr<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

switch (m_lightSource->type()) {