Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: components/autofill/browser/webdata/web_data_service_unittest.cc

Issue 16154031: Un-refcount AutofillWebData and TokenWebData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/webdata/web_data_service_unittest.cc
diff --git a/components/autofill/browser/webdata/web_data_service_unittest.cc b/components/autofill/browser/webdata/web_data_service_unittest.cc
index 98f03138a02920b23e3f3583a97d12b299f92422..811d3085146ac8afa65f6c703a4f2621ad3d3312 100644
--- a/components/autofill/browser/webdata/web_data_service_unittest.cc
+++ b/components/autofill/browser/webdata/web_data_service_unittest.cc
@@ -76,15 +76,15 @@ class WebDataServiceTest : public testing::Test {
wdbs_->AddTable(scoped_ptr<WebDatabaseTable>(new AutofillTable("en-US")));
wdbs_->LoadDatabase();
- wds_ = new AutofillWebDataService(
- wdbs_, WebDataServiceBase::ProfileErrorCallback());
+ wds_.reset(new AutofillWebDataService(
+ wdbs_, WebDataServiceBase::ProfileErrorCallback()));
wds_->Init();
}
virtual void TearDown() {
wds_->ShutdownOnUIThread();
wdbs_->ShutdownDatabase();
- wds_ = NULL;
+ wds_.reset();
wdbs_ = NULL;
WaitForDatabaseThread();
@@ -107,7 +107,7 @@ class WebDataServiceTest : public testing::Test {
content::TestBrowserThread ui_thread_;
content::TestBrowserThread db_thread_;
base::FilePath profile_dir_;
- scoped_refptr<AutofillWebDataService> wds_;
+ scoped_ptr<AutofillWebDataService> wds_;
scoped_refptr<WebDatabaseService> wdbs_;
base::ScopedTempDir temp_dir_;
};
@@ -135,7 +135,8 @@ class WebDataServiceAutofillTest : public WebDataServiceTest {
BrowserThread::PostTask(
BrowserThread::DB,
FROM_HERE,
- base::Bind(add_observer_func, wds_, &observer_));
+ base::Bind(add_observer_func,
+ base::Unretained(wds_.get()), &observer_));
WaitForDatabaseThread();
}
@@ -146,7 +147,8 @@ class WebDataServiceAutofillTest : public WebDataServiceTest {
BrowserThread::PostTask(
BrowserThread::DB,
FROM_HERE,
- base::Bind(remove_observer_func, wds_, &observer_));
+ base::Bind(remove_observer_func,
+ base::Unretained(wds_.get()), &observer_));
WaitForDatabaseThread();
WebDataServiceTest::TearDown();

Powered by Google App Engine
This is Rietveld 408576698