Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: trunk/src/base/base.gyp

Issue 16154020: Revert 203907 "Modify base_unittests.exe to use the allocator shims" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/base.gyp
===================================================================
--- trunk/src/base/base.gyp (revision 203910)
+++ trunk/src/base/base.gyp (working copy)
@@ -754,9 +754,9 @@
'message_pump_glib_unittest.cc',
]
}],
+ # This is needed to trigger the dll copy step on windows.
+ # TODO(mark): This should not be necessary.
['OS == "win"', {
- # This is needed to trigger the dll copy step on windows.
- # TODO(mark): This should not be necessary.
'dependencies': [
'../third_party/icu/icu.gyp:icudata',
],
@@ -770,18 +770,6 @@
'msvs_disabled_warnings': [
4267,
],
- # This is needed so base_unittests uses the allocator shim, as
- # SecurityTest.MemoryAllocationRestriction* tests are dependent
- # on tcmalloc.
- # TODO(wfh): crbug.com/246278 Move tcmalloc specific tests into
- # their own test suite.
- 'conditions': [
- ['win_use_allocator_shim==1', {
- 'dependencies': [
- 'allocator/allocator.gyp:allocator',
- ],
- }],
- ],
}, { # OS != "win"
'dependencies': [
'../third_party/libevent/libevent.gyp:libevent'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698