Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 16154020: Revert 203907 "Modify base_unittests.exe to use the allocator shims" (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 6 months ago
Reviewers:
Will Harris
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 203907 "Modify base_unittests.exe to use the allocator shims" Fails to compile: 88>allocator.lib(allocator_shim.obj) :error LNK2005: "void * __cdecl operator new[](unsigned int,struct std::nothrow_t const &)" (??_U@YAPAXIABUnothrow_t@std@@@Z) already defined in libcmt.lib(newaopnt.obj) 88>..\build\Release\base_unittests.exe : fatalerror LNK1169: one or more multiply defined symbols found > Modify base_unittests.exe to use the allocator shims > required to use tcmalloc on Windows. > > This fixes failing SecurityTest.MemoryAllocationRestriction > tests which are testing the tcmalloc 2Gb memory limits > imposed for security > > BUG=242304 > > Review URL: https://chromiumcodereview.appspot.com/15674003 TBR=wfh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M trunk/src/base/base.gyp View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
7 years, 6 months ago (2013-06-04 10:38:14 UTC) #1
jochen (gone - plz use gerrit)
7 years, 6 months ago (2013-06-04 10:38:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r203911.

Powered by Google App Engine
This is Rietveld 408576698