tests/language/lazy_static3_test.dart - Issue 16154017: Rename RuntimeError to CyclicIntializationError, as per spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/language/lazy_static3_test.dart

Issue 16154017: Rename RuntimeError to CyclicIntializationError, as per spec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('K') | « tests/isolate/global_error_handler_test.dart ('k') | tests/lib/async/run_async4_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/language/lazy_static3_test.dart

diff --git a/tests/language/lazy_static3_test.dart b/tests/language/lazy_static3_test.dart

index 76186f6e75b089c1697f60a1741e9cc43dcb36bd..ee412e1baa038a28edf4cecb7973e152bae642e7 100644

--- a/tests/language/lazy_static3_test.dart

+++ b/tests/language/lazy_static3_test.dart

@@ -45,7 +45,7 @@ main() {

Expect.throws(() => fib(x2), (e) => e == "interrupt initialization");

Expect.equals(499, x2);

- Expect.throws(() => fib(x3), (e) => e is RuntimeError);

+ Expect.throws(() => fib(x3), (e) => e is CyclicInitializationError);

Johnni Winther 2013/06/04 09:58:52 Doesn't this change make the test fail?

Lasse Reichstein Nielsen 2013/06/04 10:21:08 The VM already fails this test. I think it just th

Expect.equals(null, x3);

Expect.equals(499, x4);

@@ -54,5 +54,5 @@ main() {

Expect.equals(499, x6);

- Expect.throws(() => fib(x7), (e) => e is RuntimeError);

+ Expect.throws(() => fib(x7), (e) => e is CyclicInitializationError);

Johnni Winther 2013/06/04 09:58:52 Ditto.

Lasse Reichstein Nielsen 2013/06/04 10:21:08 Ditto too.

}