Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 16154007: [Telemetry] Add a page set option to use all cold page loads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use devtool's cache clearing Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 8f5aec0924f4edc3d07eb61f7d60ac47ae603188..b39571c70a6d66dd7755326a5adeb3f791456663 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -234,6 +234,8 @@ class PageRunner(object):
self._PreparePage(page, tab, page_state, test, results)
test.Run(options, page, tab, results)
util.CloseConnections(tab)
nduca 2013/06/20 19:54:15 and this for that matter shoudl move into page sta
tonyg 2013/06/21 22:36:18 Agreed. I decided not to touch CloseConnections in
+ if options.cold_page_loads:
nduca 2013/06/20 19:54:15 lets make this part of clean up page also, to ask
tonyg 2013/06/21 22:36:18 Really good point. I put this into PreparePage.
+ tab.ClearCache()
except page_test.Failure:
logging.warning('%s:\n%s', page.url, traceback.format_exc())
results.AddFailure(page, sys.exc_info())
« tools/telemetry/telemetry/core/browser_options.py ('K') | « tools/telemetry/telemetry/core/tab.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698