Issue 16154004: Fix two CPU profiler tests on ARM and MIPS simulators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16154004: Fix two CPU profiler tests on ARM and MIPS simulators (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, loislo, alph, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix two CPU profiler tests on ARM and MIPS simulators Use Simulator::get_pc instead of Simulator::get_register(pc) as the latter will return value adjusted by Instruction::kPCReadOffset. BUG=v8:2628 R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14880

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -22 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/sampler.cc	View	3 chunks	+6 lines, -12 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 5 (0 generated)

Sven Panne

LGTM, too. Please wait with landing until our bots are greener...

7 years, 6 months ago (2013-05-29 08:42:34 UTC) #3

yurys

On 2013/05/29 08:42:34, Sven Panne wrote: > LGTM, too. Please wait with landing until our ...

7 years, 6 months ago (2013-05-29 08:43:59 UTC) #4

yurys

7 years, 6 months ago (2013-05-29 12:09:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r14880 (presubmit successful).