Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 16153008: Re-enable SSLUITest.TestGoodFrameNavigation and adjust to new behaviour now (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_browser_tests.cc
===================================================================
--- chrome/browser/ssl/ssl_browser_tests.cc (revision 201401)
+++ chrome/browser/ssl/ssl_browser_tests.cc (working copy)
@@ -1291,7 +1291,7 @@
// - navigate to a bad HTTPS (expect unsafe content and filtered frame), then
// back
// - navigate to HTTP (expect insecure content), then back
-IN_PROC_BROWSER_TEST_F(SSLUITest, DISABLED_TestGoodFrameNavigation) {
+IN_PROC_BROWSER_TEST_F(SSLUITest, TestGoodFrameNavigation) {
ASSERT_TRUE(test_server()->Start());
ASSERT_TRUE(https_server_.Start());
ASSERT_TRUE(https_server_expired_.Start());
@@ -1376,8 +1376,8 @@
observer.Wait();
}
- // Our state should be insecure.
- CheckAuthenticatedState(tab, true);
+ // Our state should be unathenticated (in the ran mixed script sense)
+ CheckUnauthenticatedState(tab);
Lei Zhang 2013/05/29 20:06:34 How does this compile correctly when CheckAuthenti
// Go back, our state should be unchanged.
{
@@ -1387,7 +1387,7 @@
tab->GetController().GoBack();
observer.Wait();
}
- CheckAuthenticatedState(tab, true);
+ CheckUnauthenticatedState(tab);
}
// From a bad HTTPS top frame:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698