Re-enable SSLUITest.TestGoodFrameNavigation and adjust to new behaviour now

Re-enable SSLUITest.TestGoodFrameNavigation and adjust to new behaviour now
that the Blink roll is sticking.

BUG=238484
R=abarth@chromium.org, thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203039

[Chris Evans, 2013-05-29 19:38:44]

Ah, just noticed that abarth@ is an OWNER for ssl/

[Lei Zhang, 2013-05-29 20:06:34]

https://codereview.chromium.org/16153008/diff/1/chrome/browser/ssl/ssl_browse...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/16153008/diff/1/chrome/browser/ssl/ssl_browse...
chrome/browser/ssl/ssl_browser_tests.cc:1380: CheckUnauthenticatedState(tab);
How does this compile correctly when CheckAuthenticatedState() takes 2
parameters?

[Chris Evans, 2013-05-29 20:15:25]

On 2013/05/29 20:06:34, Lei Zhang wrote:
>
https://codereview.chromium.org/16153008/diff/1/chrome/browser/ssl/ssl_browse...
> File chrome/browser/ssl/ssl_browser_tests.cc (right):
> 
>
https://codereview.chromium.org/16153008/diff/1/chrome/browser/ssl/ssl_browse...
> chrome/browser/ssl/ssl_browser_tests.cc:1380: CheckUnauthenticatedState(tab);
> How does this compile correctly when CheckAuthenticatedState() takes 2
> parameters?

Because it's not calling CheckAuthenticatedState, it's now
CheckUnauthenticatedState :)

[Lei Zhang, 2013-05-29 20:18:40]

I'll defer to abarth since he probably knows more about what's going on.

[abarth-chromium, 2013-05-29 20:21:36]

LGTM

[Lei Zhang, 2013-05-30 02:52:38]

lgtm to patch set 2.

The Check* methods can probably use some refactoring at another time to combine
the very similarly structured code.

[Chris Evans, 2013-05-30 03:27:07]

Committed patchset #2 manually as r203039 (presubmit successful).