Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1615253003: Updates DCHECK in mojo/runner/context.cc to match reality (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates DCHECK in mojo/runner/context.cc to match reality Needs to be updated now that we honor single-process. BUG=none TEST=none R=jam@chromium.org Committed: https://crrev.com/a0728f758b8a845c8153b6d54948958c2fdc0d16 Cr-Commit-Position: refs/heads/master@{#371051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/runner/context.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 11 months ago (2016-01-21 23:43:44 UTC) #1
jam
lgtm
4 years, 11 months ago (2016-01-22 20:23:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615253003/1
4 years, 11 months ago (2016-01-22 21:04:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 21:55:00 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 21:56:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0728f758b8a845c8153b6d54948958c2fdc0d16
Cr-Commit-Position: refs/heads/master@{#371051}

Powered by Google App Engine
This is Rietveld 408576698