Reland mac symbol test.

Reland mac symbol test.

This reverts commit be50aafa27c1ebcc4a292ea415c74c75279b4961.

Previously our crash symbol parsing was not taking into account other
files that are also loaded in (especially in debug builds).

R=nednguyen@google.com
BUG=563716
Committed: https://crrev.com/7a8e19c9730f6edbdac25868a4e9725c46ce5704
Cr-Commit-Position: refs/heads/master@{#371939}

[David Yen, 2016-01-22 00:28:16]

On 2016/01/22 00:25:56, David Yen wrote:

For the debug build all the symbols are scattered around in other libraries,
I've modified the script to locate all known libraries as well. PTAL.

[nednguyen, 2016-01-22 02:33:50]

On 2016/01/22 00:28:16, David Yen wrote:
> On 2016/01/22 00:25:56, David Yen wrote:
> 
> For the debug build all the symbols are scattered around in other libraries,
> I've modified the script to locate all known libraries as well. PTAL.

You probably now want to make the change to telemetry/ in catapult/

[David Yen, 2016-01-22 21:53:33]

On 2016/01/22 02:33:50, nednguyen wrote:
> On 2016/01/22 00:28:16, David Yen wrote:
> > On 2016/01/22 00:25:56, David Yen wrote:
> > 
> > For the debug build all the symbols are scattered around in other libraries,
> > I've modified the script to locate all known libraries as well. PTAL.
> 
> You probably now want to make the change to telemetry/ in catapult/

Would that by any chance be the reason why even testStackTrace is failing? I
can't figure out how that test could be failing.

[David Yen, 2016-01-22 22:26:53]

On 2016/01/22 21:53:33, David Yen wrote:
> On 2016/01/22 02:33:50, nednguyen wrote:
> > On 2016/01/22 00:28:16, David Yen wrote:
> > > On 2016/01/22 00:25:56, David Yen wrote:
> > > 
> > > For the debug build all the symbols are scattered around in other
libraries,
> > > I've modified the script to locate all known libraries as well. PTAL.
> > 
> > You probably now want to make the change to telemetry/ in catapult/
> 
> Would that by any chance be the reason why even testStackTrace is failing? I
> can't figure out how that test could be failing.

Nevermind, I think I figured it out. I'll upload it to catapult once I verify
the bot is green.

[David Yen, 2016-01-27 22:14:44]

On 2016/01/22 22:26:53, David Yen wrote:
> On 2016/01/22 21:53:33, David Yen wrote:
> > On 2016/01/22 02:33:50, nednguyen wrote:
> > > On 2016/01/22 00:28:16, David Yen wrote:
> > > > On 2016/01/22 00:25:56, David Yen wrote:
> > > > 
> > > > For the debug build all the symbols are scattered around in other
> libraries,
> > > > I've modified the script to locate all known libraries as well. PTAL.
> > > 
> > > You probably now want to make the change to telemetry/ in catapult/
> > 
> > Would that by any chance be the reason why even testStackTrace is failing? I
> > can't figure out how that test could be failing.
> 
> Nevermind, I think I figured it out. I'll upload it to catapult once I verify
> the bot is green.

Test passed on the bot, should be ready to go now.

[nednguyen, 2016-01-27 22:18:36]

lgtm

Good luck

[David Yen, 2016-01-27 22:46:18]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2016-01-27 22:47:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615173003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615173003/60001

[David Yen, 2016-01-27 22:54:59]

On 2016/01/27 22:18:36, nednguyen wrote:
> lgtm
> 
> Good luck

I think we got it this time! :)

[commit-bot: I haz the power, 2016-01-28 00:39:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 00:40:12]

Description was changed from

==========
Reland mac symbol test.

This reverts commit be50aafa27c1ebcc4a292ea415c74c75279b4961.

Previously our crash symbol parsing was not taking into account other
files that are also loaded in (especially in debug builds).

R=nednguyen@google.com
BUG=563716
==========

to

==========
Reland mac symbol test.

This reverts commit be50aafa27c1ebcc4a292ea415c74c75279b4961.

Previously our crash symbol parsing was not taking into account other
files that are also loaded in (especially in debug builds).

R=nednguyen@google.com
BUG=563716

Committed: https://crrev.com/7a8e19c9730f6edbdac25868a4e9725c46ce5704
Cr-Commit-Position: refs/heads/master@{#371939}
==========

[commit-bot: I haz the power, 2016-01-28 00:40:13]

Patchset 4 (id:??) landed as
https://crrev.com/7a8e19c9730f6edbdac25868a4e9725c46ce5704
Cr-Commit-Position: refs/heads/master@{#371939}