content/browser/font_access/font_getter_default.cc - Issue 1615133002: Implement API for accessing fonts installed locally on the system.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/font_access/font_getter_default.cc

Issue 1615133002: Implement API for accessing fonts installed locally on the system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/font_access/font_getter.cc ('K') | « content/browser/font_access/font_getter.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | content/common/font_access/font_description.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/font_access/font_getter.h"

	6

	7 namespace content {
	nasko 2016/02/12 22:05:18 Empty line after namespace. Empty line after namespace. Daniel Nishi 2016/02/12 22:49:40 Done. Show quoted text On 2016/02/12 22:05:18, nasko (away for February) wrote: > Empty line after namespace. Done.
	8 scoped_ptr<FontCacheMap> GetFontCacheMap() {

	9 scoped_ptr<FontCacheMap> empty_map(new FontCacheMap());

	10 return empty_map;
	nasko 2016/02/12 22:05:18 Why do you need a _default.cc file instead of fold Why do you need a _default.cc file instead of folding this into the main font_getter.cc? Daniel Nishi 2016/02/12 22:49:40 Other OS implementations will implement the GetFon Show quoted text On 2016/02/12 22:05:18, nasko (away for February) wrote: > Why do you need a _default.cc file instead of folding this into the main > font_getter.cc? Other OS implementations will implement the GetFontCacheMap method and only the correct implementation will be compiled for the OS (i.e. the default will not be). The default implementation will only be compiled in for OSes which do not have an implementation of the GetFontCacheMap method yet.
	11 }

	12 } // namespace content
	nasko 2016/02/12 22:05:18 Empty line above. Empty line above. Daniel Nishi 2016/02/12 22:49:40 Done. Show quoted text On 2016/02/12 22:05:18, nasko (away for February) wrote: > Empty line above. Done.
OLD	NEW