Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1615073007: Add a test of summaries that uses strong mode. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test of summaries that uses strong mode. This will be expanded once we start storing inferred types in summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/daa7a4ee3224f7fcf115f1b0fde0f55dce08a342

Patch Set 1 #

Patch Set 2 : Fix test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 2 chunks +22 lines, -5 lines 0 comments Download
A pkg/analyzer/test/src/summary/summarize_elements_strong_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_elements_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-21 22:56:09 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-21 23:47:57 UTC) #3
Paul Berry
Whoops, I failed to test this correctly and there were test failures. PTAL.
4 years, 11 months ago (2016-01-22 01:01:27 UTC) #4
scheglov
LGTM
4 years, 11 months ago (2016-01-22 01:13:10 UTC) #5
Paul Berry
4 years, 11 months ago (2016-01-22 01:13:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
daa7a4ee3224f7fcf115f1b0fde0f55dce08a342 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698