Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1615063002: [interpreter] Fix return address when entering exception handler. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix return address when entering exception handler. This fixes the broken return address when the exception handler within interpreted bytecode is being entered via stack unwinding. The address in question will never actually be taken, but our stack walker uses this address to determine whether a frame is interpreted. R=rmcilroy@chromium.org TEST=cctest/test-interpreter/InterpreterTryCatch BUG=v8:4674 LOG=n Committed: https://crrev.com/ca51c204e1ab1519e2c623a74fad117577c37732 Cr-Commit-Position: refs/heads/master@{#33463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-21 17:44:52 UTC) #2
rmcilroy
lgtm, thanks
4 years, 11 months ago (2016-01-22 10:59:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615063002/1
4 years, 11 months ago (2016-01-22 11:15:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 11:16:21 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 11:17:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca51c204e1ab1519e2c623a74fad117577c37732
Cr-Commit-Position: refs/heads/master@{#33463}

Powered by Google App Engine
This is Rietveld 408576698