Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1615023003: Add ability to query read pixels support without a render target. (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixsupp
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ability to query read pixels support without a render target. Add more checks to onGetReadPixelsInfo. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1615023003 Committed: https://skia.googlesource.com/skia/+/1aa202935ff698f1f35c5435455073fd9f1d08de

Patch Set 1 #

Patch Set 2 : add newline #

Total comments: 2

Patch Set 3 : squash with prev cl in series #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -30 lines) Patch
M src/gpu/gl/GrGLCaps.h View 1 2 4 chunks +9 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 chunks +21 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 2 chunks +62 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bsalomon
Adds more checks to onGetReadPixelsInfo that it's temp draw manipulations will actually succeed.
4 years, 11 months ago (2016-01-21 21:10:52 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1615023003/diff/20001/src/gpu/gl/GrGLGpu.h File src/gpu/gl/GrGLGpu.h (right): https://codereview.chromium.org/1615023003/diff/20001/src/gpu/gl/GrGLGpu.h#newcode166 src/gpu/gl/GrGLGpu.h:166: pixels -> pixel ? Here and in other ...
4 years, 11 months ago (2016-01-22 14:56:11 UTC) #4
bsalomon
Squashed 1615143002 into this https://codereview.chromium.org/1615023003/diff/20001/src/gpu/gl/GrGLGpu.h File src/gpu/gl/GrGLGpu.h (right): https://codereview.chromium.org/1615023003/diff/20001/src/gpu/gl/GrGLGpu.h#newcode166 src/gpu/gl/GrGLGpu.h:166: On 2016/01/22 14:56:10, robertphillips wrote: ...
4 years, 11 months ago (2016-01-22 15:50:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615023003/40001
4 years, 11 months ago (2016-01-22 15:52:59 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 16:09:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615023003/40001
4 years, 11 months ago (2016-01-22 16:15:25 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 16:16:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1aa202935ff698f1f35c5435455073fd9f1d08de

Powered by Google App Engine
This is Rietveld 408576698