third_party/WebKit/Source/web/WebInputElement.cpp - Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebInputElement.cpp

Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set to -1 for invalid attribute or negative Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebInputElement.cpp

diff --git a/third_party/WebKit/Source/web/WebInputElement.cpp b/third_party/WebKit/Source/web/WebInputElement.cpp

index 139b51078efd8589f5fface4e70b03deae1fcb2e..6b3e47868a21caed457d340bb7ab01386553102a 100644

--- a/third_party/WebKit/Source/web/WebInputElement.cpp

+++ b/third_party/WebKit/Source/web/WebInputElement.cpp

@@ -83,7 +83,8 @@ bool WebInputElement::isCheckbox() const

int WebInputElement::maxLength() const

{

- return constUnwrap<HTMLInputElement>()->maxLength();

+ int maxLen = constUnwrap<HTMLInputElement>()->maxLength();

+ return maxLen == -1 ? HTMLInputElement::maximumLength : maxLen;

}

void WebInputElement::setActivatedSubmit(bool activated)

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | third_party/WebKit/public/web/WebInputElement.h » ('j') | no next file with comments »