components/autofill/core/common/form_field_data.cc - Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/form_field_data.cc

Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix interactive tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/form_field_data.h ('k') | components/autofill/core/common/form_field_data_unittest.cc » ('j') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/form_field_data.cc

diff --git a/components/autofill/core/common/form_field_data.cc b/components/autofill/core/common/form_field_data.cc

index 7b8d10530d424d6b6ed074839da294398c59ea50..1fe57db6cb1ff74c3b1ba0fba809cd4ecebd5981 100644

--- a/components/autofill/core/common/form_field_data.cc

+++ b/components/autofill/core/common/form_field_data.cc

@@ -57,7 +57,7 @@ bool DeserializeCommonSection1(base::PickleIterator* iter,

iter->ReadString16(&field_data->value) &&

iter->ReadString(&field_data->form_control_type) &&

iter->ReadString(&field_data->autocomplete_attribute) &&

- iter->ReadSizeT(&field_data->max_length) &&

+ iter->ReadInt(&field_data->max_length) &&

iter->ReadBool(&field_data->is_autofilled) &&

iter->ReadBool(&field_data->is_checked) &&

iter->ReadBool(&field_data->is_checkable) &&

@@ -155,7 +155,7 @@ void SerializeFormFieldData(const FormFieldData& field_data,

pickle->WriteString16(field_data.value);

pickle->WriteString(field_data.form_control_type);

pickle->WriteString(field_data.autocomplete_attribute);

- pickle->WriteSizeT(field_data.max_length);

+ pickle->WriteInt(field_data.max_length);

pickle->WriteBool(field_data.is_autofilled);

pickle->WriteBool(field_data.is_checked);

pickle->WriteBool(field_data.is_checkable);