components/autofill/core/browser/phone_field.cc - Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/phone_field.cc

Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix interactive tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/phone_field.h ('k') | components/autofill/core/common/form_field_data.h » ('j') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/phone_field.cc

diff --git a/components/autofill/core/browser/phone_field.cc b/components/autofill/core/browser/phone_field.cc

index a8810ec48f72382577b5f4c1e36cd5db073107e8..601a0a0a2fe4217a613a26b80b00a34bb033bce2 100644

--- a/components/autofill/core/browser/phone_field.cc

+++ b/components/autofill/core/browser/phone_field.cc

@@ -151,7 +151,7 @@ scoped_ptr<FormField> PhoneField::Parse(AutofillScanner* scanner) {

&parsed_fields[kPhoneFieldGrammars[i].phone_part]))

break;

if (kPhoneFieldGrammars[i].max_size &&

- (!parsed_fields[kPhoneFieldGrammars[i].phone_part]->max_length ||

+ (parsed_fields[kPhoneFieldGrammars[i].phone_part]->max_length <= 0 ||

kPhoneFieldGrammars[i].max_size <

parsed_fields[kPhoneFieldGrammars[i].phone_part]->max_length)) {

break;