components/autofill/core/browser/autofill_field.cc - Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_field.cc

Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix interactive tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/core/browser/credit_card_field.cc » ('j') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_field.cc

diff --git a/components/autofill/core/browser/autofill_field.cc b/components/autofill/core/browser/autofill_field.cc

index 754ec0175be74bfcf416f6c51d84048fdc0f2eaf..c9c5720cdaa457e35010d50626b4c3fa35a17583 100644

--- a/components/autofill/core/browser/autofill_field.cc

+++ b/components/autofill/core/browser/autofill_field.cc

@@ -596,7 +596,7 @@ base::string16 AutofillField::GetPhoneNumberValue(

// provide a valid number for the field. For example, the number 15142365264

// with a field with a max length of 10 would return 5142365264, thus removing

// the country code and remaining valid.

- if (number.length() > field_data.max_length) {

+ if (static_cast<int>(number.length()) > field_data.max_length && field_data.max_length > -1) {

return number.substr(number.length() - field_data.max_length,

field_data.max_length);

}