Fix behavior of HTMLInputElement.maxLength/minLength getter

third_party/WebKit/Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 1347 matching lines @@
     return parseAcceptAttribute(fastGetAttribute(acceptAttr), isValidFileExtension);
 }
 
 const AtomicString& HTMLInputElement::alt() const
 {
     return fastGetAttribute(altAttr);
 }
 
 int HTMLInputElement::maxLength() const
 {
+    if (!hasAttribute(maxlengthAttr) || m_maxLength == maximumLength)

[tkent, 2016/02/08 23:48:21]

input.maxLength for <input maxlength="524288"> returns -1.  It's not right.

+        return -1;
     return m_maxLength;
 }
 
 int HTMLInputElement::minLength() const
 {
+    if (!hasAttribute(minlengthAttr))

[tkent, 2016/02/08 23:48:21]

We should have a test for this change.

I think we can change the initial value of m_minLength to -1.

+        return -1;
     return m_minLength;
 }
 
 void HTMLInputElement::setMaxLength(int maxLength, ExceptionState& exceptionState)
 {
     if (maxLength < 0)
         exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(maxLength) + ") is negative.");
     else if (maxLength < m_minLength)
         exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::indexExceedsMinimumBound("maxLength", maxLength, m_minLength));
     else
@@ skipping 548 matching lines @@
 void HTMLInputElement::ensurePrimaryContent()
 {
     m_inputTypeView->ensurePrimaryContent();
 }
 
 bool HTMLInputElement::hasFallbackContent() const
 {
     return m_inputTypeView->hasFallbackContent();
 }
 } // namespace blink