Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Side by Side Diff: components/autofill/core/common/form_field_data.h

Issue 1615003002: Fix behavior of HTMLInputElement.maxLength/minLength getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try to fix interactive tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_FORM_FIELD_DATA_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_FORM_FIELD_DATA_H_
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_FORM_FIELD_DATA_H_ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_FORM_FIELD_DATA_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 27 matching lines...) Expand all
38 // Comparison operator exposed for STL map. Uses label, then name to sort. 38 // Comparison operator exposed for STL map. Uses label, then name to sort.
39 bool operator<(const FormFieldData& field) const; 39 bool operator<(const FormFieldData& field) const;
40 40
41 // If you add more, be sure to update the comparison operator, SameFieldAs, 41 // If you add more, be sure to update the comparison operator, SameFieldAs,
42 // serializing functions (in the .cc file) and the constructor. 42 // serializing functions (in the .cc file) and the constructor.
43 base::string16 label; 43 base::string16 label;
44 base::string16 name; 44 base::string16 name;
45 base::string16 value; 45 base::string16 value;
46 std::string form_control_type; 46 std::string form_control_type;
47 std::string autocomplete_attribute; 47 std::string autocomplete_attribute;
48 size_t max_length; 48 int max_length;
49 bool is_autofilled; 49 bool is_autofilled;
50 bool is_checked; 50 bool is_checked;
51 bool is_checkable; 51 bool is_checkable;
52 bool is_focusable; 52 bool is_focusable;
53 bool should_autocomplete; 53 bool should_autocomplete;
54 RoleAttribute role; 54 RoleAttribute role;
55 base::i18n::TextDirection text_direction; 55 base::i18n::TextDirection text_direction;
56 56
57 // For the HTML snippet |<option value="US">United States</option>|, the 57 // For the HTML snippet |<option value="US">United States</option>|, the
58 // value is "US" and the contents are "United States". 58 // value is "US" and the contents are "United States".
(...skipping 22 matching lines...) Expand all
81 EXPECT_EQ(expected.autocomplete_attribute, actual.autocomplete_attribute); \ 81 EXPECT_EQ(expected.autocomplete_attribute, actual.autocomplete_attribute); \
82 EXPECT_EQ(expected.max_length, actual.max_length); \ 82 EXPECT_EQ(expected.max_length, actual.max_length); \
83 EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \ 83 EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \
84 EXPECT_EQ(expected.is_checked, actual.is_checked); \ 84 EXPECT_EQ(expected.is_checked, actual.is_checked); \
85 EXPECT_EQ(expected.is_checkable, actual.is_checkable); \ 85 EXPECT_EQ(expected.is_checkable, actual.is_checkable); \
86 } while (0) 86 } while (0)
87 87
88 } // namespace autofill 88 } // namespace autofill
89 89
90 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_FIELD_DATA_H_ 90 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_FIELD_DATA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698