Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 16150003: Revert "Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice" (Closed)

Created:
7 years, 6 months ago by rossberg
Modified:
7 years, 6 months ago
Reviewers:
rafaelw
CC:
v8-dev, adamk
Visibility:
Public.

Description

Revert "Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice" This reverts commit r14846. Broke Mozilla test (see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/3608/steps/Mozilla/logs/stdio), e.g.: === mozilla/js1_5/Array/regress-451483 === --- stdout --- BUGNUMBER: 451483 STATUS: [].splice.call(0) == [] /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/Array/regress-451483.js:57: illegal access var result = [].splice.call(0); ^ Command: /mnt/data/b/build/slave/v8-linux-shared/build/v8/out/Release/d8 --test --nobreak-on-abort --nodead-code-elimination --nofold-constants --expose-gc /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/mozilla-shell-emulation.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/shell.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/shell.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/Array/shell.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/Array/regress-451483.js TBR=rafaelw@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -207 lines) Patch
M src/array.js View 10 chunks +34 lines, -143 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 3 chunks +16 lines, -64 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
7 years, 6 months ago (2013-05-28 13:00:39 UTC) #1
rossberg
7 years, 6 months ago (2013-05-28 13:01:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r14851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698