Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 16150002: Implement special origin database handling for Isolated Apps (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
jam, tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org, awong
Visibility:
Public.

Description

Implement special origin database handling for Isolated Apps - Factor out SandboxOriginDatabase interface to SandboxOriginDatabaseInterface - Implement SandboxIsolatedOriginDatabase which implements the same interface and only handles a single origin without database BUG=242272 TEST=SandboxIsolatedOriginDatabaseTest.* TEST=manually tested (launch Chrome w/o change, launch an app which uses HTML5 FS API, write some data -> launch Chrome with change, make sure the same contents appear & origin database's gone) TBR=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203139

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -77 lines) Patch
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 4 chunks +14 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 12 chunks +49 lines, -21 lines 0 comments Download
A webkit/browser/fileapi/sandbox_isolated_origin_database.h View 1 chunk +40 lines, -0 lines 0 comments Download
A webkit/browser/fileapi/sandbox_isolated_origin_database.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
A webkit/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.h View 3 chunks +19 lines, -30 lines 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.cc View 10 chunks +27 lines, -23 lines 0 comments Download
A webkit/browser/fileapi/sandbox_origin_database_interface.h View 1 chunk +55 lines, -0 lines 0 comments Download
A webkit/browser/fileapi/sandbox_origin_database_interface.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/webkit_browser_fileapi.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
PTL
7 years, 6 months ago (2013-05-29 05:31:32 UTC) #1
tzik
lgtm
7 years, 6 months ago (2013-05-29 08:38:24 UTC) #2
kinuko
Changed the default origin directory name from "000" to "iso" (of 'isolated'), as I wanted ...
7 years, 6 months ago (2013-05-30 02:44:19 UTC) #3
kinuko
7 years, 6 months ago (2013-05-30 13:04:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r203139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698