Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1614993002: Do not try to load empty images (Closed)

Created:
4 years, 11 months ago by Miguel Garcia
Modified:
4 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not try to load empty images BUG=580091 Committed: https://crrev.com/19f699674c7d2fe5675d4257781961dff56fe3a0 Cr-Commit-Position: refs/heads/master@{#370711}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/notifications/notification_ui_manager_mac.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Miguel Garcia
4 years, 11 months ago (2016-01-21 15:42:53 UTC) #2
Peter Beverloo
lgtm
4 years, 11 months ago (2016-01-21 15:44:53 UTC) #3
Robert Sesek
LGTM
4 years, 11 months ago (2016-01-21 15:48:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614993002/20001
4 years, 11 months ago (2016-01-21 15:49:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 16:17:06 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 16:18:45 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/19f699674c7d2fe5675d4257781961dff56fe3a0
Cr-Commit-Position: refs/heads/master@{#370711}

Powered by Google App Engine
This is Rietveld 408576698