Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1614973002: Added roundss to the disassembler of x64 and ia32. (Closed)

Created:
4 years, 11 months ago by ahaas
Modified:
4 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Added roundss to the disassembler of x64 and ia32. R=titzer@chromium.org Committed: https://crrev.com/37ff07ec16bdf9a70f2f7af05b9eaafb38c06b77 Cr-Commit-Position: refs/heads/master@{#33440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/ia32/disasm-ia32.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 11 months ago (2016-01-21 15:10:19 UTC) #1
titzer
lgtm
4 years, 11 months ago (2016-01-21 15:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614973002/1
4 years, 11 months ago (2016-01-21 15:48:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 15:50:33 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:51:05 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/37ff07ec16bdf9a70f2f7af05b9eaafb38c06b77
Cr-Commit-Position: refs/heads/master@{#33440}

Powered by Google App Engine
This is Rietveld 408576698