Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Issue 1614953003: Make gfx::Display Final (Closed)

Created:
4 years, 11 months ago by robliao
Modified:
4 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make gfx::Display Final gfx::Display is designed to be copied, so no one should inherit from gfx::Display. BUG=426656 Committed: https://crrev.com/7dd2b7db1707e2ee9dc52c84cfe632fbf20b7d36 Cr-Commit-Position: refs/heads/master@{#370774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/display.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
robliao
Split CL from https://codereview.chromium.org/1426933002/
4 years, 11 months ago (2016-01-21 18:37:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614953003/1
4 years, 11 months ago (2016-01-21 18:39:16 UTC) #4
oshima
lgtm
4 years, 11 months ago (2016-01-21 18:45:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 20:01:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614953003/1
4 years, 11 months ago (2016-01-21 20:27:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:36:10 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:37:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7dd2b7db1707e2ee9dc52c84cfe632fbf20b7d36
Cr-Commit-Position: refs/heads/master@{#370774}

Powered by Google App Engine
This is Rietveld 408576698