src/heap/store-buffer.cc - Issue 1614953002: [heap] Cleanup: Remove WAS_SWEPT flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/store-buffer.cc

Issue 1614953002: [heap] Cleanup: Remove WAS_SWEPT flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/store-buffer.cc

diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc

index 06b44a6d435e1bb186d8ecb3a25a157670e1376c..71b1e95da9488b6ea3deb953626331645fba8114 100644

--- a/src/heap/store-buffer.cc

+++ b/src/heap/store-buffer.cc

@@ -476,7 +476,7 @@ void StoreBuffer::IteratePointersToNewSpace(ObjectSlotCallback slot_callback) {

Page* page = reinterpret_cast<Page*>(chunk);

PagedSpace* owner = reinterpret_cast<PagedSpace*>(page->owner());

if (owner == heap_->map_space()) {

- DCHECK(page->WasSwept());

+ DCHECK(page->SweepingCompleted());

HeapObjectIterator iterator(page);

for (HeapObject* heap_object = iterator.Next(); heap_object != NULL;

heap_object = iterator.Next()) {