[heap] Cleanup: Remove WAS_SWEPT flag.

[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel
R=hpayer@chromium.org

Committed: https://crrev.com/5eff5420545a39709928a98782609d486c6c9ec7
Cr-Commit-Position: refs/heads/master@{#33490}

[Michael Lippautz, 2016-01-21 14:17:45]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2016-01-21 14:28:47]

Description was changed from

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state.
- Rename the state accordingly.

BUG=
==========

to

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

BUG=
==========

[Michael Lippautz, 2016-01-21 15:31:18]

Description was changed from

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

BUG=
==========

to

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

R=hpayer@chromium.org
==========

[Michael Lippautz, 2016-01-21 15:31:35]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-01-21 15:32:15]

https://codereview.chromium.org/1614953002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1614953002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:731:
pages.push_back(std::make_pair(p->LiveBytesFromFreeList(), p));
We only collect evacuation candidates at the start of (incremental) marking,
i.e., after we have finished sweeping.

https://codereview.chromium.org/1614953002/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (left):

https://codereview.chromium.org/1614953002/diff/20001/src/heap/spaces.h#oldco...
src/heap/spaces.h:2108: static bool ShouldBeSweptBySweeperThreads(Page* p) {
It's dead Jim.

https://codereview.chromium.org/1614953002/diff/20001/test/cctest/heap/test-h...
File test/cctest/heap/test-heap.cc (left):

https://codereview.chromium.org/1614953002/diff/20001/test/cctest/heap/test-h...
test/cctest/heap/test-heap.cc:5594: Page* page =
Page::FromAddress(o->elements()->address());
As far as I see this the test (at least the last part) is bogus, as we cannot
concurrently check marking bits in the case that the sweeper is still running.

(The test was initially added in a lazy/parallel sweeping scenario, where it
actually made sense.)

[Michael Lippautz, 2016-01-21 15:35:17]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 15:35:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614953002/40001

[commit-bot: I haz the power, 2016-01-21 15:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 15:58:35]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-01-25 11:15:44]

lgtm

https://codereview.chromium.org/1614953002/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1614953002/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3849: 
remove this newline

https://codereview.chromium.org/1614953002/diff/40001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1614953002/diff/40001/src/heap/spaces.h#newco...
src/heap/spaces.h:857: bool SweepingCompleted() {
Let's rename that to SweepingDone to reflect the actual state.

[Michael Lippautz, 2016-01-25 11:46:30]

Description was changed from

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

R=hpayer@chromium.org
==========

to

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel
R=hpayer@chromium.org
==========

[Michael Lippautz, 2016-01-25 11:46:39]

https://codereview.chromium.org/1614953002/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1614953002/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3849: 
On 2016/01/25 11:15:44, Hannes Payer wrote:
> remove this newline

Done.

https://codereview.chromium.org/1614953002/diff/40001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1614953002/diff/40001/src/heap/spaces.h#newco...
src/heap/spaces.h:857: bool SweepingCompleted() {
On 2016/01/25 11:15:44, Hannes Payer wrote:
> Let's rename that to SweepingDone to reflect the actual state.

Done.

[Michael Lippautz, 2016-01-25 11:47:11]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-01-25 11:47:11]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1614953002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-01-25 11:47:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614953002/60001

[commit-bot: I haz the power, 2016-01-25 12:33:05]

Description was changed from

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel
R=hpayer@chromium.org
==========

to

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel
R=hpayer@chromium.org
==========

[commit-bot: I haz the power, 2016-01-25 12:33:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-25 12:33:40]

Description was changed from

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel
R=hpayer@chromium.org
==========

to

==========
[heap] Cleanup: Remove WAS_SWEPT flag.

- Completely rely on the concurrent sweeping state for SweepingCompleted()
- Rename the state accordingly.

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel
R=hpayer@chromium.org

Committed: https://crrev.com/5eff5420545a39709928a98782609d486c6c9ec7
Cr-Commit-Position: refs/heads/master@{#33490}
==========

[commit-bot: I haz the power, 2016-01-25 12:33:41]

Patchset 3 (id:??) landed as
https://crrev.com/5eff5420545a39709928a98782609d486c6c9ec7
Cr-Commit-Position: refs/heads/master@{#33490}