Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1614943004: Revert of Uniquify profile shortcut name. (Closed)

Created:
4 years, 11 months ago by Alexei Svitkine (slow)
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Uniquify profile shortcut name. (patchset #4 id:60001 of https://codereview.chromium.org/1540543002/ ) Reason for revert: Reverting since it broke tests on official bots: https://code.google.com/p/chromium/issues/detail?id=580073 Original issue's description: > Uniquify profile shortcut name. > > Profile desktop shortcut can have a name that conflicts with existing > shortcuts. This commit tries to fix it by uniquifying shortcut name: by > appending "(2)", "(3)" ... suffix if there is a conflict. > If there are two or more profiles with identical logical names they are all > able to have desktop shortcuts at the same time now. > > R=erg@chromium.org > > BUG=572593 > > Committed: https://crrev.com/915cc7306b0899ed017f7656dd82de8a4e4184ec > Cr-Commit-Position: refs/heads/master@{#370625} TBR=calamity@chromium.org,anthonyvd@chromium.org,gab@chromium.org,thakis@chromium.org,mkolom@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=572593 Committed: https://crrev.com/7eead05316a7e77b238a1563f1c9dafbe3a781df Cr-Commit-Position: refs/heads/master@{#370701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -362 lines) Patch
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 2 chunks +1 line, -144 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.h View 2 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 9 chunks +65 lines, -191 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Alexei Svitkine (slow)
Created Revert of Uniquify profile shortcut name.
4 years, 11 months ago (2016-01-21 15:42:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614943004/1
4 years, 11 months ago (2016-01-21 15:43:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 15:44:52 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:47:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eead05316a7e77b238a1563f1c9dafbe3a781df
Cr-Commit-Position: refs/heads/master@{#370701}

Powered by Google App Engine
This is Rietveld 408576698