Add Lua SkXfermode skp scraping support

Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes. AFAICT they should not so this is just to verify.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1614923002

Committed: https://skia.googlesource.com/skia/+/233bab918f1ca44c260b1481b79d9fa5951186e2

[robertphillips, 2016-01-21 13:23:36]

Description was changed from

==========
Add Lua SkXfermode skp scraping support
==========

to

==========
Add Lua SkXfermode skp scraping support
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-21 13:26:10]

Description was changed from

==========
Add Lua SkXfermode skp scraping support
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes.
AFAICT they should not so this is just to verify.

The only controversial part of this is the addition of 'getLuaName' to
SkXfermode

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-21 13:26:10]

robertphillips@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-01-21 14:39:11]

lgtm w/ privatization question

https://codereview.chromium.org/1614923002/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/1614923002/diff/1/include/core/SkXfermode.h#n...
include/core/SkXfermode.h:249: virtual void luaGetName(SkString* name) const {
name->set("Unknown"); }
can this be private?

[reed1, 2016-01-21 14:41:36]

Doesn't SkFlattenable::getTypeName() serve the same purpose?

[robertphillips, 2016-01-21 16:33:01]

It sure does! I've removed all the junk code.

[robertphillips, 2016-01-21 16:33:07]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 16:33:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614923002/20001

[commit-bot: I haz the power, 2016-01-21 16:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 16:49:06]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-21 17:04:47]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-01-21 17:04:48]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1614923002/#ps20001
(title: "use SkFlattenable::getTypeName")

[commit-bot: I haz the power, 2016-01-21 17:04:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614923002/20001

[commit-bot: I haz the power, 2016-01-21 17:05:34]

Description was changed from

==========
Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes.
AFAICT they should not so this is just to verify.

The only controversial part of this is the addition of 'getLuaName' to
SkXfermode

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes.
AFAICT they should not so this is just to verify.

The only controversial part of this is the addition of 'getLuaName' to
SkXfermode

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/233bab918f1ca44c260b1481b79d9fa5951186e2
==========

[commit-bot: I haz the power, 2016-01-21 17:05:35]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/233bab918f1ca44c260b1481b79d9fa5951186e2

[robertphillips, 2016-01-25 17:57:22]

Description was changed from

==========
Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes.
AFAICT they should not so this is just to verify.

The only controversial part of this is the addition of 'getLuaName' to
SkXfermode

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/233bab918f1ca44c260b1481b79d9fa5951186e2
==========

to

==========
Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes.
AFAICT they should not so this is just to verify.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/233bab918f1ca44c260b1481b79d9fa5951186e2
==========