Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1614913002: Fixes disappearing text in Find in page toolbar in slide over. (Closed)

Created:
4 years, 11 months ago by stkhapugin
Modified:
4 years, 11 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes disappearing text in Find in page toolbar in slide over. Find in page text is persisted through UIPasteboard that is always returning nil when the application is running in background. Because of this, when the application with Find in page is backgrounded and tries to back up and recreate text, it sometimes removes all traces of the find in page query by restoring it from pasteboard in background. This behavior is new to iOS 9 and undocumented, although well known. BUG=532912 TEST=Navigate to any page and find something in page. Backgroudn the app and open it as slideover over any other app (Calendar). Check that the search query is persisted through this operation. Committed: https://crrev.com/ccca3cf7c1801a86a3f762c83fb6907204026691 Cr-Commit-Position: refs/heads/master@{#370684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/chrome/browser/find_in_page/find_in_page_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stkhapugin
PTAL
4 years, 11 months ago (2016-01-21 13:04:03 UTC) #2
droger
lgtm
4 years, 11 months ago (2016-01-21 13:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614913002/1
4 years, 11 months ago (2016-01-21 13:24:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 13:42:16 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 13:44:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccca3cf7c1801a86a3f762c83fb6907204026691
Cr-Commit-Position: refs/heads/master@{#370684}

Powered by Google App Engine
This is Rietveld 408576698