Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1614843006: Don't update the title to about:blank on first show for custom tabs (Closed)

Created:
4 years, 11 months ago by Yusuf
Modified:
4 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't update the title to about:blank on first show for custom tabs Currently custom tabs don't show a title if the title is still the url, but due to optimizations inside warmup(), the title might end up being about:blank (even if the current url is not about:blank). The domain explicitly guards against this but title doesn't. Update the title to also never show about:blank BUG=579647 Committed: https://crrev.com/0551ff294144d38973bfdf2e01f08aabaaff5b22 Cr-Commit-Position: refs/heads/master@{#371276}

Patch Set 1 #

Patch Set 2 : Added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yusuf
4 years, 11 months ago (2016-01-22 22:07:04 UTC) #2
gone
lgtm
4 years, 11 months ago (2016-01-25 18:34:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614843006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614843006/20001
4 years, 11 months ago (2016-01-25 18:36:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 19:23:51 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 19:26:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0551ff294144d38973bfdf2e01f08aabaaff5b22
Cr-Commit-Position: refs/heads/master@{#371276}

Powered by Google App Engine
This is Rietveld 408576698