DescriptionRevert of Fix org.chromium.chrome.browser.GeolocationTest (patchset #1 id:1 of https://codereview.chromium.org/1599113002/ )
Reason for revert:
Causing downstream test failures on ToT bots (blocking Chromium rolls downstream)
Original issue's description:
> Fix org.chromium.chrome.browser.GeolocationTest
>
> The geolocation tests did not work because:
> - They referred to incorrect test pages.
> Correct test pages:
> https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_on_load.html
> https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_watch_on_load.html
> - A race condition was causing LocationProviderAdapter.newLocationAvailable() to
> be often called prior to LocationProviderFactory.LocationProvider.start().
>
> In addition to fixing the above problems, this CL makes
> org.chromium.chrome.browser.GeolocationTest more similar to
> - org.chromium.android_webview.test.GeolocationTest
> - org.chromium.content.browser.ContentViewLocationTest
> In particular, all of the tests now:
> - Use the same test page
> - Use MockLocationProvider
>
> BUG=141518
> Test=Less flakiness
>
> Committed: https://crrev.com/5228d5afe9d76431d7cca53eb1ea73b715e49e7e
> Cr-Commit-Position: refs/heads/master@{#370807}
TBR=mvanouwerkerk@chromium.org,tedchoc@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=141518
Committed: https://crrev.com/29dfa24c18f479c9e68d45a7daf9ba48afe00019
Cr-Commit-Position: refs/heads/master@{#370871}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|