Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1614843005: Revert of Fix org.chromium.chrome.browser.GeolocationTest (Closed)

Created:
4 years, 11 months ago by mikecase (-- gone --)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix org.chromium.chrome.browser.GeolocationTest (patchset #1 id:1 of https://codereview.chromium.org/1599113002/ ) Reason for revert: Causing downstream test failures on ToT bots (blocking Chromium rolls downstream) Original issue's description: > Fix org.chromium.chrome.browser.GeolocationTest > > The geolocation tests did not work because: > - They referred to incorrect test pages. > Correct test pages: > https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_on_load.html > https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_watch_on_load.html > - A race condition was causing LocationProviderAdapter.newLocationAvailable() to > be often called prior to LocationProviderFactory.LocationProvider.start(). > > In addition to fixing the above problems, this CL makes > org.chromium.chrome.browser.GeolocationTest more similar to > - org.chromium.android_webview.test.GeolocationTest > - org.chromium.content.browser.ContentViewLocationTest > In particular, all of the tests now: > - Use the same test page > - Use MockLocationProvider > > BUG=141518 > Test=Less flakiness > > Committed: https://crrev.com/5228d5afe9d76431d7cca53eb1ea73b715e49e7e > Cr-Commit-Position: refs/heads/master@{#370807} TBR=mvanouwerkerk@chromium.org,tedchoc@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=141518 Committed: https://crrev.com/29dfa24c18f479c9e68d45a7daf9ba48afe00019 Cr-Commit-Position: refs/heads/master@{#370871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -68 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java View 3 chunks +112 lines, -51 lines 0 comments Download
M content/test/data/android/geolocation.html View 1 chunk +7 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mikecase (-- gone --)
Created Revert of Fix org.chromium.chrome.browser.GeolocationTest
4 years, 11 months ago (2016-01-22 01:45:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614843005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614843005/1
4 years, 11 months ago (2016-01-22 01:46:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 01:48:17 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 01:50:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29dfa24c18f479c9e68d45a7daf9ba48afe00019
Cr-Commit-Position: refs/heads/master@{#370871}

Powered by Google App Engine
This is Rietveld 408576698