Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1614843002: Revert of Moving mac_chromium_asan_rel_ng to cq_builders for better resource allocation (Closed)

Created:
4 years, 11 months ago by Paweł Hajdan Jr.
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, iannucci, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Moving mac_chromium_asan_rel_ng to cq_builders for better resource allocation (patchset #1 id:1 of https://codereview.chromium.org/1597553003/ ) Reason for revert: We're now seeing pending queues for CQ builders in this pool. mac_chromium_asan_rel_ng is not a CQ builder, so moving it back to optional pool. I'm also removing it from a CQ experiment, see https://codereview.chromium.org/1611163002 . If you'd like to request more resources, please do so explicitly. Original issue's description: > Moving mac_chromium_asan_rel_ng from optional1_builders to cq_builders for better resource allocation > Since optional1_slaves only has 2 bots, it is possible for the estimated resource capacity to reach 6 based on the past month's load. cq_builders has capacity of around 90 bots and seldom goes above 60, so requests to mac_chromium_asan_rel_ng can be handled by bots in cq_builders instead to prevent jobs from piling up in the pending queue. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298291 TBR=sergeyberezin@chromium.org,lijeffrey@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M masters/master.tryserver.chromium.mac/slaves.cfg View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paweł Hajdan Jr.
Created Revert of Moving mac_chromium_asan_rel_ng to cq_builders for better resource allocation
4 years, 11 months ago (2016-01-21 11:21:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614843002/1
4 years, 11 months ago (2016-01-21 11:21:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298334
4 years, 11 months ago (2016-01-21 11:23:40 UTC) #4
Sergey Berezin
4 years, 11 months ago (2016-01-21 19:23:28 UTC) #5
Message was sent while issue was closed.
FWIW, I don't think this revert was necessary, since the builder was removed
from CQ experiment. And I also don't think we need to allocate more machines for
a 10% experiment - we already have enough. 

I suspect a bug in "git cl try" which triggers experimental builders by default,
and that's the cause of the problem.

Powered by Google App Engine
This is Rietveld 408576698