Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1614793002: Merge setMediaRouteController and setRouteController for NotificationTransportControl (Closed)

Created:
4 years, 11 months ago by aberent
Modified:
4 years, 11 months ago
Reviewers:
whywhat, dgn
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge setMediaRouteController and setRouteController for NotificationTransportControl BUG=363159 Committed: https://crrev.com/bd2aa27a66386b6c03b612c6a83c6e4ee70df6ad Cr-Commit-Position: refs/heads/master@{#370662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java View 3 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
aberent
Trivial fix, but has its own bug, so done as a separate CL.
4 years, 11 months ago (2016-01-21 09:46:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614793002/1
4 years, 11 months ago (2016-01-21 09:48:20 UTC) #4
dgn
lgtm
4 years, 11 months ago (2016-01-21 09:50:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614793002/1
4 years, 11 months ago (2016-01-21 09:51:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 10:34:13 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:35:16 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bd2aa27a66386b6c03b612c6a83c6e4ee70df6ad
Cr-Commit-Position: refs/heads/master@{#370662}

Powered by Google App Engine
This is Rietveld 408576698