third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html - Issue 1614733002: Reland of Remove MockConstraints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

Issue 1614733002: Reland of Remove MockConstraints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/test_runner.gyp ('k') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

index 13da90042be296e9fb14190ea52e6f4fd5b8316b..2624d778851a9ee3a02b50aa6002ffa7e3550283 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

@@ -52,7 +52,8 @@ shouldThrow("new webkitRTCPeerConnection(null, {mandatory:{valid_but_unsupported

shouldThrow("new webkitRTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1, valid_and_supported_1:1}});");

shouldThrow("new webkitRTCPeerConnection(null, {optional:{valid_and_supported_1:0}});");

shouldThrow("new webkitRTCPeerConnection(null, {optional:[{valid_and_supported_1:0,valid_and_supported_2:0}]});");

-shouldThrow("new webkitRTCPeerConnection(null, {optional:[{invalid:0}]});");

+// Optional constraints are ignored even if they are invalid.

+shouldNotThrow("new webkitRTCPeerConnection(null, {optional:[{invalid:0}]});");

shouldThrow("new webkitRTCPeerConnection(null, {valid_and_supported_1:1});");

shouldThrow("new webkitRTCPeerConnection(null, {valid_but_unsupported_1:1});");

shouldThrow("new webkitRTCPeerConnection(null, {valid_and_supported_2:1, mandatory:{valid_and_supported_1:1}});");