tools/perf/measurements/session_restore.py - Issue 161473002: [Android] Don't wait for background tabs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/session_restore.py

Issue 161473002: [Android] Don't wait for background tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tonyg@ comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/perf/metrics/startup_metric.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from measurements import startup	5 from measurements import startup

6 from metrics import cpu	6 from metrics import cpu

7 from metrics import startup_metric	7 from metrics import startup_metric

8	8

9	9

10 class SessionRestore(startup.Startup):	10 class SessionRestore(startup.Startup):

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43	43

44 if len(wpr_archives.keys()) > 1:	44 if len(wpr_archives.keys()) > 1:

45 raise Exception("Invalid pageset: more than 1 WPR archive found.: " +	45 raise Exception("Invalid pageset: more than 1 WPR archive found.: " +

46 ', '.join(wpr_archives.keys()))	46 ', '.join(wpr_archives.keys()))

47	47

48 def DidStartBrowser(self, browser):	48 def DidStartBrowser(self, browser):

49 self._cpu_metric = cpu.CpuMetric(browser)	49 self._cpu_metric = cpu.CpuMetric(browser)

50 self._cpu_metric.Start(None, None)	50 self._cpu_metric.Start(None, None)

51	51

52 def MeasurePage(self, page, tab, results):	52 def MeasurePage(self, page, tab, results):

53 # Wait for all tabs to finish loading.

54 for i in xrange(len(tab.browser.tabs)):

55 t = tab.browser.tabs[i]

56 t.WaitForDocumentReadyStateToBeComplete()

57	53

	54 tab.browser.foreground_tab.WaitForDocumentReadyStateToBeComplete()

58 # Record CPU usage from browser start to when all pages have loaded.	55 # Record CPU usage from browser start to when all pages have loaded.

59 self._cpu_metric.Stop(None, None)	56 self._cpu_metric.Stop(None, None)

60 self._cpu_metric.AddResults(tab, results, 'cpu_utilization')	57 self._cpu_metric.AddResults(tab, results, 'cpu_utilization')

61	58

62 startup_metric.StartupMetric().AddResults(tab, results)	59 startup_metric.StartupMetric().AddResults(tab, results)

63	60

64 # TODO(jeremy): Measure time to load - first, last and frontmost tab here.	61 # TODO(jeremy): Measure time to load - first, last and frontmost tab here.

OLD	NEW